Run resolveUrl for protocol-relative urls #5530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This part of ABS_URL is trying to match on absolute paths, like `/images/logo.png` not protocol-relative urls like `//example.com/images/logo.png` Upstreaming cl/245302268
rictic
requested review from
TimvdLippe,
dfreedm,
kevinpschaaf and
sorvell
as code owners
sorvell
suggested changes
Apr 25, 2019
Contributor
sorvell
left a comment
sorvell
left a comment
There was a problem hiding this comment.
Seems ok but should have a test.
Also cleaned up a some over-aggressive modulizer escaping in resolveurl-elements.js
sorvell
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of ABS_URL is trying to match on absolute paths, like
/images/logo.pngnot protocol-relative urls like//example.com/images/logo.pngUpstreaming cl/245302268