Revert isAttached change based on review feedback. Deemed a breaking change.

Steven Orvell · Steven Orvell · commit 1ff51e6800b0 · 2019-09-13T09:16:05.000-07:00
diff --git a/lib/legacy/legacy-element-mixin.js b/lib/legacy/legacy-element-mixin.js
@@ -122,8 +122,8 @@ export const LegacyElementMixin = dedupingMixin((base) => {
      * @override
      */
     connectedCallback() {
-      this.isAttached = true;
       super.connectedCallback();
+      this.isAttached = true;
       this.attached();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -122,8 +122,8 @@ export const LegacyElementMixin = dedupingMixin((base) => {`
`122`	`122`	`* @override`
`123`	`123`	`*/`
`124`	`124`	`connectedCallback() {`
`125`		`- this.isAttached = true;`
`126`	`125`	`super.connectedCallback();`
	`126`	`+ this.isAttached = true;`
`127`	`127`	`this.attached();`
`128`	`128`	`}`
`129`	`129`