[12.0] [FIX] web: properly handle form state with nested notebooks #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: 1. Create a form with a notebook, with pages "A", "B", and "C" 2. In page "B", create another notebook with a name="notebook_B", and pages "1", "2", and "3". 3. Create a record on this form, and focus on page "B" and then page "3". 4. Click on the "Edit" button Result: - The page "C" is focused Expected: - Focus shouldn't change Explanation: The focused page is handled by the `getLocalState` and `setLocalState` methods, which are used to store the focused page index for each notebook on the form. However, the code doesn't handle properly the case of nested forms: when trying to identify the focused page index, it's looping through all the nested pages. This commit modifies the selector used to only look for the direct page elements.
cyrilmanuel
approved these changes
Feb 12, 2025
PaoloYam
approved these changes
Feb 12, 2025
|
This PR has the |
|
hi @pedrobaeza , is it possible to merge this one ? |
Member
|
Hi, I don't think it's worth the ratio risk/benefit to compromise the stability of such an old version for something that can have side effects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Result:
Expected:
Explanation:
The focused page is handled by the
getLocalStateandsetLocalStatemethods, which are used to store the focused page index for each notebook on the form.However, the code doesn't handle properly the case of nested forms: when trying to identify the focused page index, it's looping through all the nested pages.
This commit modifies the selector used to only look for the direct page elements.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr