-
-
Notifications
You must be signed in to change notification settings - Fork 2
Develop #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #24
Conversation
Add ARM glslangValidator fix to PATH in workflow
Removed ARM glslangValidator fix from PATH.
Add ARM architecture cleanup for Vulkan SDK.
Removed ARM-specific cleanup for glslangValidator from the action.
Updated Vulkan SDK bin directory addition to auto-detect architecture and adjusted package installation commands.
Updated Clang version and added WiX installation steps.
.github/workflows/Linux_arm.yml
Outdated
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 23 days ago
To fix the problem, explicitly set the least privileges required for the GITHUB_TOKEN used in this workflow by adding a permissions block. The recommended way is to place the permissions at the root of the workflow (as a sibling of name and on), which sets permissions globally for all jobs that do not have their own permissions block. Since no details about the actions or steps inside the reused workflow are provided, the minimal starting point is to restrict permissions to contents: read, which is sufficient for basic read operations and does not grant write access. If later steps do need elevated permissions (like pull-requests: write), these can be added or further specified per-job. For now, add the block at line 2, after the workflow name, and before on:.
No imports, new methods, or other code changes are required—just this one addition to the YAML file.
-
Copy modified lines R2-R3
| @@ -1,4 +1,6 @@ | ||
| name: Linux build + test + coverage on Ubuntu 24.04 ARM | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
.github/workflows/Windows.yml
Outdated
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 23 days ago
How to, in general terms, fix the problem:
Explicitly set workflow (or job-level) permissions using the permissions key to limit the GITHUB_TOKEN to the smallest privilege necessary. For typical build/test workflows, contents: read is usually sufficient.
Detailed steps for this workflow:
- Add a
permissions:block at the top level of.github/workflows/Windows.yml(belowname:and beforeon:) to set the workflow token permissions. - Set
contents: readas a minimal, secure starting point. - If in the future jobs require greater permissions, further keys (e.g.,
pull-requests: write) could be selectively added per job as needed.
Files/regions/lines to change:
- Insert a
permissions:block between lines 1 and 3 in.github/workflows/Windows.yml.
What is needed (methods, imports, definitions) to implement the change:
- No new imports or code methods needed; just YAML edit.
-
Copy modified lines R3-R5
| @@ -1,5 +1,8 @@ | ||
| name: Windows Server 2025 build x86 MSVC and Clang | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main, develop] |
No description provided.