fix inconsistent serialize and deserialize in ClientboundPlayerInfoUpdate (#737)

cxzlw · web-flow · commit d84fa717fab3 · 2023-07-01T19:34:43.000-04:00
* fix inconsistent serialize and deserialize in ClientboundPlayerInfoUpdatePacket.java (issue #736) * fix writePositionSource always throws IllegalStateException (issue #738)
diff --git a/src/main/java/com/github/steveice10/mc/protocol/packet/ingame/clientbound/ClientboundPlayerInfoUpdatePacket.java b/src/main/java/com/github/steveice10/mc/protocol/packet/ingame/clientbound/ClientboundPlayerInfoUpdatePacket.java
@@ -107,6 +107,7 @@ public void serialize(ByteBuf out, MinecraftCodecHelper helper) {
                 switch (action) {
                     case ADD_PLAYER:
                         helper.writeString(out, entry.getProfile().getName());
+                        helper.writeVarInt(out, entry.getProfile().getProperties().size());
                         for (GameProfile.Property property : entry.getProfile().getProperties()) {
                             helper.writeProperty(out, property);
                         }

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,7 @@ public void serialize(ByteBuf out, MinecraftCodecHelper helper) {`
`107`	`107`	`switch (action) {`
`108`	`108`	`case ADD_PLAYER:`
`109`	`109`	`helper.writeString(out, entry.getProfile().getName());`
	`110`	`+ helper.writeVarInt(out, entry.getProfile().getProperties().size());`
`110`	`111`	`for (GameProfile.Property property : entry.getProfile().getProperties()) {`
`111`	`112`	`helper.writeProperty(out, property);`
`112`	`113`	`}`