Add final static packet instance for ServerboundAcceptCodeOfConductPacket / ServerboundFinishConfigurationPacket

Author: onebeastchris

protocol/src/main/java/org/geysermc/mcprotocollib/protocol/ClientListener.java

@@ -155,7 +155,7 @@ public void packetReceived(Session session, Packet packet) {
                 session.send(new ServerboundKeepAlivePacket(keepAlivePacket.getPingId()));
             } else if (packet instanceof ClientboundFinishConfigurationPacket) {
                 session.switchInboundState(() -> protocol.setInboundState(ProtocolState.GAME));
-                session.send(new ServerboundFinishConfigurationPacket());
+                session.send(ServerboundFinishConfigurationPacket.INSTANCE);
                 session.switchOutboundState(() -> protocol.setOutboundState(ProtocolState.GAME));
             } else if (packet instanceof ClientboundSelectKnownPacks) {
                 if (session.getFlag(MinecraftConstants.SEND_BLANK_KNOWN_PACKS_RESPONSE, true)) {

protocol/src/main/java/org/geysermc/mcprotocollib/protocol/codec/MinecraftCodec.java

@@ -277,13 +277,13 @@ public class MinecraftCodec {
                     .registerServerboundPacket(ServerboundClientInformationPacket.class, ServerboundClientInformationPacket::new)
                     .registerServerboundPacket(ServerboundCookieResponsePacket.class, ServerboundCookieResponsePacket::new)
                     .registerServerboundPacket(ServerboundCustomPayloadPacket.class, ServerboundCustomPayloadPacket::new)
-                    .registerServerboundPacket(ServerboundFinishConfigurationPacket.class, ServerboundFinishConfigurationPacket::new)
+                    .registerServerboundPacket(ServerboundFinishConfigurationPacket.class, (buf) -> ServerboundFinishConfigurationPacket.INSTANCE)
                     .registerServerboundPacket(ServerboundKeepAlivePacket.class, ServerboundKeepAlivePacket::new)
                     .registerServerboundPacket(ServerboundPongPacket.class, ServerboundPongPacket::new)
                     .registerServerboundPacket(ServerboundResourcePackPacket.class, ServerboundResourcePackPacket::new)
                     .registerServerboundPacket(ServerboundSelectKnownPacks.class, ServerboundSelectKnownPacks::new)
                     .registerServerboundPacket(ServerboundCustomClickActionPacket.class, ServerboundCustomClickActionPacket::new)
-                    .registerServerboundPacket(ServerboundAcceptCodeOfConductPacket.class, ServerboundAcceptCodeOfConductPacket::new)
+                    .registerServerboundPacket(ServerboundAcceptCodeOfConductPacket.class, (buf) -> ServerboundAcceptCodeOfConductPacket.INSTANCE)
             ).state(ProtocolState.GAME, MinecraftPacketRegistry.builder()
                     .registerClientboundPacket(ClientboundDelimiterPacket.class, ClientboundDelimiterPacket::new)
                     .registerClientboundPacket(ClientboundAddEntityPacket.class, ClientboundAddEntityPacket::new)

protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/configuration/serverbound/ServerboundAcceptCodeOfConductPacket.java

@@ -1,11 +1,14 @@
 package org.geysermc.mcprotocollib.protocol.packet.configuration.serverbound;
 
 import io.netty.buffer.ByteBuf;
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
 import org.geysermc.mcprotocollib.protocol.codec.MinecraftPacket;
+import org.geysermc.mcprotocollib.protocol.packet.ingame.serverbound.ServerboundClientTickEndPacket;
 
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class ServerboundAcceptCodeOfConductPacket implements MinecraftPacket {
-
-    public ServerboundAcceptCodeOfConductPacket(ByteBuf in) {}
+    public static final ServerboundAcceptCodeOfConductPacket INSTANCE = new ServerboundAcceptCodeOfConductPacket();
 
     @Override
     public void serialize(ByteBuf out) {}

protocol/src/main/java/org/geysermc/mcprotocollib/protocol/packet/configuration/serverbound/ServerboundFinishConfigurationPacket.java

@@ -1,16 +1,15 @@
 package org.geysermc.mcprotocollib.protocol.packet.configuration.serverbound;
 
 import io.netty.buffer.ByteBuf;
+import lombok.AccessLevel;
 import lombok.Data;
 import lombok.NoArgsConstructor;
 import org.geysermc.mcprotocollib.protocol.codec.MinecraftPacket;
 
 @Data
-@NoArgsConstructor
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
 public class ServerboundFinishConfigurationPacket implements MinecraftPacket {
-
-    public ServerboundFinishConfigurationPacket(ByteBuf in) {
-    }
+    public static final ServerboundFinishConfigurationPacket INSTANCE = new ServerboundFinishConfigurationPacket();
 
     public void serialize(ByteBuf out) {
     }