Add GEdit-Bench and ImgEdit-Bench for Bagel Model #923
+4,292
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
reviewed
Dec 6, 2025
Comment on lines
+1060
to
+1064
| # Ensure dataset is a DatasetDict so downstream logic that expects multiple splits works. | ||
| if not isinstance(self.dataset, datasets.DatasetDict): | ||
| split_name = self.config.test_split or self.config.validation_split or self.config.training_split or "train" | ||
| self.dataset = datasets.DatasetDict({split_name: self.dataset}) | ||
|
|
Collaborator
There was a problem hiding this comment.
This is a too ground breaking changes. Might break too much
kcz358
reviewed
Dec 6, 2025
Comment on lines
+1071
to
+1074
| try: | ||
| self.dataset_no_image = self.dataset.copy() | ||
| except AttributeError: | ||
| self.dataset_no_image = datasets.DatasetDict({k: v for k, v in self.dataset.items()}) |
Collaborator
There was a problem hiding this comment.
Might be breaking changes also. Consider not to use this.
kcz358
reviewed
Dec 6, 2025
Collaborator
There was a problem hiding this comment.
To be honest, edit and gen doesn't seems should be fixed. It simply depends on the input.
kcz358
reviewed
Dec 6, 2025
Collaborator
There was a problem hiding this comment.
No need to put the entire source code into here.
kcz358
reviewed
Dec 6, 2025
Collaborator
kcz358
left a comment
kcz358
left a comment
There was a problem hiding this comment.
Too much breaking changes here in this PR. I would recommend to clean up and re-open a new one later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GEdit-Bench and ImgEdit-Bench Eval Task and Modify Bagel model for inference
GEdit-Bench Results:
ImgEdit-Bench Results:
