Fix Ola path for GPUs #562
Conversation
|
@kcz358 Hi I fixed the issue you mentioned. Please check again for me. |
lmms_eval/models/ola.py
Outdated
| except: | ||
| eval_logger.debug("") | ||
| from moviepy.video.io.VideoFileClip import VideoFileClip | ||
| import moviepy.editor as mp |
There was a problem hiding this comment.
Hi, may I ask which version of moviepy you are using. I think for higher level moviepy, it is better to import it with direct import. See issue
There was a problem hiding this comment.
Hi I'm using moviepy==1.0.3. I also encountered the same problem when first integrated videos for Ola, and solve by just reinstall it.
pip uninstall moviepy
pip install moviepy==1.0.3
I also fixed the import. Please help me check it.
lmms_eval/models/ola.py
Outdated
|
|
||
| def extract_audio(self, videos_file_path): | ||
| my_clip = VideoFileClip(videos_file_path) | ||
| my_clip = mp.VideoFileClip(videos_file_path) |
There was a problem hiding this comment.
Kindly check my comments above for moviepy
kcz358
left a comment
kcz358
left a comment
There was a problem hiding this comment.
Hi @Devininthelab , can you help me to check about the moviepy issue? Thanks!
|
Hi @Devininthelab , I changes a bit on the image and audio processing logic because I spotted some bugs in some cases. Feel free to check if it is correct and then I will merge the PR. Thanks! |
|
Hi I think it's okay. I got a hackathon yesterday so I forgot to check the code. |
* Fix Ola path for GPUs * Fix moviepy * Fix multi image and audio type issue --------- Co-authored-by: kcz358 <[email protected]>
* Fix Ola path for GPUs * Fix moviepy * Fix multi image and audio type issue --------- Co-authored-by: kcz358 <[email protected]>
Before you open a pull-request, please check if a similar issue already exists or has been closed before.
When you open a pull-request, please be sure to include the following
If you meet the lint warnings, you can use following scripts to reformat code.
Thank you for your contributions!