Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU.
…h both single- and multi-image samples. Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU.
…h both single- and multi-image samples. Black this file.
Luodian
approved these changes
Oct 22, 2024
KairuiHu
pushed a commit
that referenced
this pull request
Oct 24, 2024
…h both single- and multi-image samples. (#338) * Update llava_onevision.py Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Black this file.
ZhaoCinyu
pushed a commit
to ZhaoCinyu/lmms-eval
that referenced
this pull request
Dec 9, 2024
…h both single- and multi-image samples. (EvolvingLMMs-Lab#338) * Update llava_onevision.py Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Black this file.
MichalCiesiolka
pushed a commit
to MichalCiesiolka/lmms-eval-llmzszl
that referenced
this pull request
Apr 3, 2025
…h both single- and multi-image samples. (EvolvingLMMs-Lab#338) * Update llava_onevision.py Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Black this file.
dadwadw233
pushed a commit
to dadwadw233/lmms-eval
that referenced
this pull request
Apr 28, 2025
…h both single- and multi-image samples. (EvolvingLMMs-Lab#338) * Update llava_onevision.py Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Configuration rollback has been added to avoid errors on evaluation benchmarks with a mix of single and multiple images such as MMMU. * Update llava_onevision.py to avoid erros on evaluation benchmarks with both single- and multi-image samples. Black this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image_aspect_ratioby this line. This behaviour appears inloglikelihood,generate_untilandgenerate_until_multi_roundfunctions.image_aspect_ratioof all single-image samples encountered after multiple-image samples being overridden by e.g.padon benchmarks with both single-image and multiple-image samples.