[Fix] Model name None in Task manager, mix eval model specific kwargs, claude retrying fix #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcz358
changed the title
KairuiHu
pushed a commit
that referenced
this pull request
Oct 24, 2024
…, claude retrying fix (#278) * Fix task manager model name None issue * Change model specific args in mix eval to lmms eval kwargs * json dump indent 4 * lint * Fix claude always retrying 5 time error
MichalCiesiolka
pushed a commit
to MichalCiesiolka/lmms-eval-llmzszl
that referenced
this pull request
Apr 3, 2025
…, claude retrying fix (EvolvingLMMs-Lab#278) * Fix task manager model name None issue * Change model specific args in mix eval to lmms eval kwargs * json dump indent 4 * lint * Fix claude always retrying 5 time error
dadwadw233
pushed a commit
to dadwadw233/lmms-eval
that referenced
this pull request
Apr 28, 2025
…, claude retrying fix (EvolvingLMMs-Lab#278) * Fix task manager model name None issue * Change model specific args in mix eval to lmms eval kwargs * json dump indent 4 * lint * Fix claude always retrying 5 time error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you open a pull-request, please check if a similar issue already exists or has been closed before.
When you open a pull-request, please be sure to include the following
Thank you for your contributions!
We forgot to pass in the model name in the task manager, this could cause the specific kwargs to be useless. This PR is to fix this error
Also, it seems like we are always retrying in the claude. No wonder the speed is so slow.