This repository was archived by the owner on Sep 12, 2024. It is now read-only.
Hamburger menu #277
Merged
Hamburger menu #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cahllagerfeld
left a comment
Cahllagerfeld
left a comment
There was a problem hiding this comment.
One small comment. On a sidenote the tests in the pipeline are failing, could you please fix them as well 🙏
Cahllagerfeld
suggested changes
Feb 1, 2023
Member
Cahllagerfeld
left a comment
Cahllagerfeld
left a comment
There was a problem hiding this comment.
Light-Mode:
could you please adjust the icon for light-mode. Currently the SVG isn't visible in lightmode
Contributor
Author
|
|
Member
Cahllagerfeld
left a comment
Cahllagerfeld
left a comment
There was a problem hiding this comment.
Nice work! I think the last step missing is reverting the changes from Contributing.md. Then we are good to go 🙏
Cahllagerfeld
approved these changes
Feb 5, 2023
Contributor
Author
@Cahllagerfeld , found the issue. I added new test for mobile devices as the old test code was unable to execute the test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Added feature requested in issue #227
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers