This repository was archived by the owner on Oct 10, 2024. It is now read-only.
fix: handle http protocol capitalization when checking links #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiejaoude
approved these changes
Jul 2, 2024
Member
eddiejaoude
left a comment
eddiejaoude
left a comment
There was a problem hiding this comment.
Good spot! I saw someone trick the bot with this today, so perfect timing 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
It is possible currently to hide a link by capitalizing a letter in the http protocol.
This PR changes the regex to check for either case
Check List (Check all the applicable boxes)