This repository was archived by the owner on Oct 10, 2024. It is now read-only.
fix: remove URLs from content before checking for banned words #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
eddiejaoude
reviewed
Jul 28, 2024
src/alexjs/checkBannedWords.ts
Outdated
| ): Promise<EmbedBuilder[]> => { | ||
| const embeds: EmbedBuilder[] = []; | ||
| try { | ||
| const urlPattern = /https?:\/\/[^\s]+/g; |
Member
There was a problem hiding this comment.
Could we use the existing link regex check from the other file? Maybe move to the config?
EddieBot/src/links/checkLinks.ts
Lines 7 to 8 in 9fc6b25
Member
There was a problem hiding this comment.
What about moving it to a reusable config, so we don't have duplication? urlRegex.js
eddiejaoude
suggested changes
Jul 28, 2024
Member
eddiejaoude
left a comment
eddiejaoude
left a comment
There was a problem hiding this comment.
Thank you! Looks good 👍
Just 1 comment about reusing existing regex pattern
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
closes #783
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers