Corrected role assignment embed

[Vyvy-vi]

closes #446

Description

This PR fixes the ^roles embed, which used to give assignment suggestion for non-assignable roles.
That might have been misleading to people.

What's the fix used?

A check to see if the role is in selfAssignableRoles.
(Could their be better ways of doing this rather than using .includes()?)

Screenshots

Before-

After-

[github-actions]

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

[AllanRegush]

Looks Good 👍 Thank you. 😄

[AllanRegush]

(Could there be better ways of doing this rather than using .includes()?)

In this case, it's okay. Since Assigned roles is an unsorted array. includes() is just a linear search. If the array was sorted we could use a bisection search. But the list isn't very long. So, it's not ideal.

The current Big O is O(1) if it's the first entry found or a Worst Case O(n) n = the length of the array.