This repository was archived by the owner on Oct 10, 2024. It is now read-only.
fix(words): matching special unicode qoutes #460 #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
Contributor
Author
|
Thanks for reviewing @srinath1412001 |
Vyvy-vi
reviewed
Mar 7, 2021
| function stripSpecialCharacters(str: string) { | ||
| // match special symbols and replace with ' ' | ||
| str = str.replace(/[.,/#!$%?&*;:{}=\-_'"~()]/g, ' '); | ||
| str = str.replace(/[.,/#!$%?&*;:{}=\-_'"“”~()]/g, ' '); |
naomi-lgbt
approved these changes
Mar 7, 2021
Contributor
Author
|
Thanks for reviewing everyone. |
Member
|
Great collaboration EddieHubbers 🤓 (is that how you spell it?) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #460
This PR adds Left quote
“and right quote”to the special characters regex. Removing the ability to escape warnings from the bot.