Multiple fixes for path-related issues and other stuff... #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Difegue#1410 Fix Difegue#1418 Added get_archive_path for getting the archive path without going through create_path every time. Better handling of special characters when uploading files.
Difegue
requested changes
Nov 28, 2025
lib/LANraragi/Model/Upload.pm
Outdated
| # Add the file to the database ourselves so Shinobu doesn't do it | ||
| # This allows autoplugin to be ran ASAP. | ||
| my $name = add_archive_to_redis( $id, $output_file, $redis, $redis_search ); | ||
| my $name = add_archive_to_redis( $id, redis_encode( redis_decode( $output_file ) ), $redis, $redis_search ); |
Owner
There was a problem hiding this comment.
I'm quite wary of this PR making changes to effectively store encoded filenames in Redis instead of raw bytes from the FS - Historically not using the exact filepaths the host filesystem caused a ton of issues on systems with weird locales.
| $tempdir | ||
| ); | ||
|
|
||
| my $mojo_temp = tmpnam(); # Create another temp file as a target for Mojo's move_to so that the original handle can be closed |
Owner
There was a problem hiding this comment.
At a glance I'm not sure which problem this solves so it probably at least needs more commenting 🤔
What does the original handle mentioned here belong to -- The mojo $file?
Contributor
Author
There was a problem hiding this comment.
I will add them but the tl;dr is that mojo holds an open handle to the file blocking it from being moved on Windows. Yes, the $file object holds it.
Guerra24
force-pushed
the
dev
branch
3 times, most recently
from
746ee52 to
69638f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Win32::FileSystemHelper diff