Skip to content

Conversation

@Vyvy-vi
Copy link
Contributor

@Vyvy-vi Vyvy-vi commented Apr 25, 2023

Summary

fixes #83

Replaces set-output command with suggested alternative

- echo "::set-output name=markdown::$(echo $UPDATE)"
+ echo "markdown=$(echo $UPDATE)" >> $GITHUB_OUTPUT

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Added or updated test cases to test new features

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ytcards ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 6:16am

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

The tests failing can be ignored since its an unrelated issue.

I'll just do a quick manual test to make sure it works and it should be good to merge.

@DenverCoder1 DenverCoder1 changed the title fix: replace set-output fix: replace use of deprecated set-output Apr 25, 2023
@DenverCoder1 DenverCoder1 merged commit 2444ba9 into DenverCoder1:main Apr 25, 2023
@DenverCoder1
Copy link
Owner

Thanks for contributing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: The set-output command is deprecated and will be disabled soon

2 participants