PR Feedback

Author: msanatan

UnityMcpBridge/Editor/Windows/MCPForUnityEditorWindow.cs

@@ -568,12 +568,8 @@ private void AutoFirstRunSetup()
                             }
                             else
                             {
-                                bool alreadyConfigured = client.mcpType switch
-                                {
-                                    McpTypes.Codex => CodexConfigHelper.IsCodexConfigured(pythonDir),
-                                    _ => IsCursorConfigured(pythonDir)
-                                };
-
+                                CheckMcpConfiguration(client);
+                                bool alreadyConfigured = client.status == McpStatus.Configured;
                                 if (!alreadyConfigured)
                                 {
                                     ConfigureMcpClient(client);
@@ -666,12 +662,8 @@ private void RunSetupNow()
                         }
                         else
                         {
-                            bool alreadyConfigured = client.mcpType switch
-                            {
-                                McpTypes.Codex => CodexConfigHelper.IsCodexConfigured(pythonDir),
-                                _ => IsCursorConfigured(pythonDir)
-                            };
-
+                            CheckMcpConfiguration(client);
+                            bool alreadyConfigured = client.status == McpStatus.Configured;
                             if (!alreadyConfigured)
                             {
                                 ConfigureMcpClient(client);
@@ -1149,54 +1141,6 @@ private static bool ArgsEqual(string[] a, string[] b)
 			return true;
 		}
 
-		private static void WriteAtomicFile(string path, string contents)
-		{
-			string tmp = path + ".tmp";
-			string backup = path + ".backup";
-			bool writeDone = false;
-			try
-			{
-				File.WriteAllText(tmp, contents, new UTF8Encoding(false));
-				try
-				{
-					File.Replace(tmp, path, backup);
-					writeDone = true;
-				}
-				catch (FileNotFoundException)
-				{
-					File.Move(tmp, path);
-					writeDone = true;
-				}
-				catch (PlatformNotSupportedException)
-				{
-					if (File.Exists(path))
-					{
-						try { if (File.Exists(backup)) File.Delete(backup); } catch { }
-						File.Move(path, backup);
-					}
-					File.Move(tmp, path);
-					writeDone = true;
-				}
-			}
-			catch (Exception ex)
-			{
-				try
-				{
-					if (!writeDone && File.Exists(backup))
-					{
-						try { File.Copy(backup, path, true); } catch { }
-					}
-				}
-				catch { }
-				throw new Exception($"Failed to write config file '{path}': {ex.Message}", ex);
-			}
-			finally
-			{
-				try { if (File.Exists(tmp)) File.Delete(tmp); } catch { }
-				try { if (writeDone && File.Exists(backup)) File.Delete(backup); } catch { }
-			}
-		}
-
         private string WriteToConfig(string pythonDir, string configPath, McpClient mcpClient = null)
         {
 			// 0) Respect explicit lock (hidden pref or UI toggle)