feat: replace custom boolean coercion logic with shared utility function

Author: Jordonh18

Server/src/services/tools/manage_editor.py

@@ -6,6 +6,7 @@
 from services.tools import get_unity_instance_from_context
 from transport.unity_transport import send_with_unity_instance
 from transport.legacy.unity_connection import async_send_command_with_retry
+from Server.src.services.tools.utils import coerce_bool
 
 
 @mcp_for_unity_tool(
@@ -26,21 +27,7 @@ async def manage_editor(
     # Get active instance from request state (injected by middleware)
     unity_instance = get_unity_instance_from_context(ctx)
 
-    # Coerce boolean parameters defensively to tolerate 'true'/'false' strings
-    def _coerce_bool(value, default=None):
-        if value is None:
-            return default
-        if isinstance(value, bool):
-            return value
-        if isinstance(value, str):
-            v = value.strip().lower()
-            if v in ("true", "1", "yes", "on"):  # common truthy strings
-                return True
-            if v in ("false", "0", "no", "off"):
-                return False
-        return bool(value)
-
-    wait_for_completion = _coerce_bool(wait_for_completion)
+    wait_for_completion = coerce_bool(wait_for_completion)
 
     try:
         # Diagnostics: quick telemetry checks

Server/src/services/tools/manage_gameobject.py

@@ -6,6 +6,7 @@
 from services.tools import get_unity_instance_from_context
 from transport.unity_transport import send_with_unity_instance
 from transport.legacy.unity_connection import async_send_command_with_retry
+from Server.src.services.tools.utils import coerce_bool
 
 
 @mcp_for_unity_tool(
@@ -72,19 +73,6 @@ async def manage_gameobject(
     unity_instance = get_unity_instance_from_context(ctx)
 
     # Coercers to tolerate stringified booleans and vectors
-    def _coerce_bool(value, default=None):
-        if value is None:
-            return default
-        if isinstance(value, bool):
-            return value
-        if isinstance(value, str):
-            v = value.strip().lower()
-            if v in ("true", "1", "yes", "on"):
-                return True
-            if v in ("false", "0", "no", "off"):
-                return False
-        return bool(value)
-
     def _coerce_vec(value, default=None):
         if value is None:
             return default
@@ -113,12 +101,12 @@ def _to_vec3(parts):
     position = _coerce_vec(position, default=position)
     rotation = _coerce_vec(rotation, default=rotation)
     scale = _coerce_vec(scale, default=scale)
-    save_as_prefab = _coerce_bool(save_as_prefab)
-    set_active = _coerce_bool(set_active)
-    find_all = _coerce_bool(find_all)
-    search_in_children = _coerce_bool(search_in_children)
-    search_inactive = _coerce_bool(search_inactive)
-    includeNonPublicSerialized = _coerce_bool(includeNonPublicSerialized)
+    save_as_prefab = coerce_bool(save_as_prefab)
+    set_active = coerce_bool(set_active)
+    find_all = coerce_bool(find_all)
+    search_in_children = coerce_bool(search_in_children)
+    search_inactive = coerce_bool(search_inactive)
+    includeNonPublicSerialized = coerce_bool(includeNonPublicSerialized)
 
     # Coerce 'component_properties' from JSON string to dict for client compatibility
     if isinstance(component_properties, str):

Server/src/services/tools/manage_prefabs.py

@@ -5,6 +5,7 @@
 from services.tools import get_unity_instance_from_context
 from transport.unity_transport import send_with_unity_instance
 from transport.legacy.unity_connection import async_send_command_with_retry
+from Server.src.services.tools.utils import coerce_bool
 
 
 @mcp_for_unity_tool(
@@ -30,35 +31,22 @@ async def manage_prefabs(
     # Removed session_state import
     unity_instance = get_unity_instance_from_context(ctx)
 
-    def _coerce_bool(value, default=None):
-        if value is None:
-            return default
-        if isinstance(value, bool):
-            return value
-        if isinstance(value, str):
-            v = value.strip().lower()
-            if v in ("true", "1", "yes", "on"):
-                return True
-            if v in ("false", "0", "no", "off"):
-                return False
-        return bool(value)
-
     try:
         params: dict[str, Any] = {"action": action}
 
         if prefab_path:
             params["prefabPath"] = prefab_path
         if mode:
             params["mode"] = mode
-        save_before_close_val = _coerce_bool(save_before_close)
+        save_before_close_val = coerce_bool(save_before_close)
         if save_before_close_val is not None:
             params["saveBeforeClose"] = save_before_close_val
         if target:
             params["target"] = target
-        allow_overwrite_val = _coerce_bool(allow_overwrite)
+        allow_overwrite_val = coerce_bool(allow_overwrite)
         if allow_overwrite_val is not None:
             params["allowOverwrite"] = allow_overwrite_val
-        search_inactive_val = _coerce_bool(search_inactive)
+        search_inactive_val = coerce_bool(search_inactive)
         if search_inactive_val is not None:
             params["searchInactive"] = search_inactive_val
         response = await send_with_unity_instance(async_send_command_with_retry, unity_instance, "manage_prefabs", params)

Server/src/services/tools/utils.py

@@ -0,0 +1,24 @@
+"""Shared helper utilities for MCP server tools."""
+
+from __future__ import annotations
+
+from typing import Any
+
+
+_TRUTHY = {"true", "1", "yes", "on"}
+_FALSY = {"false", "0", "no", "off"}
+
+
+def coerce_bool(value: Any, default: bool | None = None) -> bool | None:
+    """Attempt to coerce a loosely-typed value to a boolean."""
+    if value is None:
+        return default
+    if isinstance(value, bool):
+        return value
+    if isinstance(value, str):
+        lowered = value.strip().lower()
+        if lowered in _TRUTHY:
+            return True
+        if lowered in _FALSY:
+            return False
+    return bool(value)