Follow-up: address CodeRabbit feedback for #308 (<GetToolsFolderIdentifier was duplicated>)

Author: JohanHoltby

MCPForUnity/Editor/Helpers/PackageDetector.cs

@@ -152,7 +152,7 @@ private static bool ToolsVersionsChanged()
                     }
 
                     // Get folder identifier (same logic as ServerInstaller.GetToolsFolderIdentifier)
-                    string folderIdentifier = GetToolsFolderIdentifier(folder);
+                    string folderIdentifier = ServerInstaller.GetToolsFolderIdentifier(folder);
                     string trackingFile = System.IO.Path.Combine(toolsDir, $"{folderIdentifier}_version.txt");
 
                     // Read installed version
@@ -177,39 +177,5 @@ private static bool ToolsVersionsChanged()
                 return true;
             }
         }
-
-        /// <summary>
-        /// Generates a unique identifier for a MCPForUnityTools folder (duplicates ServerInstaller logic).
-        /// </summary>
-        private static string GetToolsFolderIdentifier(string toolsFolderPath)
-        {
-            try
-            {
-                System.IO.DirectoryInfo parent = System.IO.Directory.GetParent(toolsFolderPath);
-                if (parent == null) return "MCPForUnityTools";
-
-                System.IO.DirectoryInfo current = parent;
-                while (current != null)
-                {
-                    string name = current.Name;
-                    System.IO.DirectoryInfo grandparent = current.Parent;
-
-                    if (grandparent != null &&
-                        (grandparent.Name.Equals("Assets", System.StringComparison.OrdinalIgnoreCase) ||
-                         grandparent.Name.Equals("Packages", System.StringComparison.OrdinalIgnoreCase)))
-                    {
-                        return $"{name}_MCPForUnityTools";
-                    }
-
-                    current = grandparent;
-                }
-
-                return $"{parent.Name}_MCPForUnityTools";
-            }
-            catch
-            {
-                return "MCPForUnityTools";
-            }
-        }
     }
 }

MCPForUnity/Editor/Helpers/ServerInstaller.cs

@@ -495,7 +495,7 @@ private static void CopyUnityProjectTools(string destToolsDir)
         /// Generates a unique identifier for a MCPForUnityTools folder based on its parent directory.
         /// Example: "Assets/MooseRunner/Editor/MCPForUnityTools" → "MooseRunner_MCPForUnityTools"
         /// </summary>
-        private static string GetToolsFolderIdentifier(string toolsFolderPath)
+        internal static string GetToolsFolderIdentifier(string toolsFolderPath)
         {
             try
             {