refactor: only add env property to config for Windsurf and Kiro clients

If it ain't broke with the other clients, don't fix...

Author: msanatan

TestProjects/UnityMCPTests/Assets/Tests/EditMode/Windows/ManualConfigJsonBuilderTests.cs

@@ -8,7 +8,7 @@ namespace MCPForUnityTests.Editor.Windows
     public class ManualConfigJsonBuilderTests
     {
         [Test]
-        public void VSCode_ManualJson_HasServersEnvType_NoDisabled()
+        public void VSCode_ManualJson_HasServers_NoEnv_NoDisabled()
         {
             var client = new McpClient { name = "VSCode", mcpType = McpTypes.VSCode };
             string json = ConfigJsonBuilder.BuildManualConfigJson("/usr/bin/uv", "/path/to/server", client);
@@ -19,7 +19,7 @@ public void VSCode_ManualJson_HasServersEnvType_NoDisabled()
             Assert.AreEqual("/usr/bin/uv", (string)unity["command"]);
             CollectionAssert.AreEqual(new[] { "run", "--directory", "/path/to/server", "server.py" }, unity["args"].ToObject<string[]>());
             Assert.AreEqual("stdio", (string)unity["type"], "VSCode should include type=stdio");
-            Assert.NotNull(unity["env"], "env should be included");
+            Assert.IsNull(unity["env"], "env should not be added for VSCode");
             Assert.IsNull(unity["disabled"], "disabled should not be added for VSCode");
         }
 
@@ -38,15 +38,15 @@ public void Windsurf_ManualJson_HasMcpServersEnv_DisabledFalse()
         }
 
         [Test]
-        public void Cursor_ManualJson_HasMcpServersEnv_NoDisabled()
+        public void Cursor_ManualJson_HasMcpServers_NoEnv_NoDisabled()
         {
             var client = new McpClient { name = "Cursor", mcpType = McpTypes.Cursor };
             string json = ConfigJsonBuilder.BuildManualConfigJson("/usr/bin/uv", "/path/to/server", client);
 
             var root = JObject.Parse(json);
             var unity = (JObject)root.SelectToken("mcpServers.unityMCP");
             Assert.NotNull(unity, "Expected mcpServers.unityMCP node");
-            Assert.NotNull(unity["env"], "env should be included");
+            Assert.IsNull(unity["env"], "env should not be added for Cursor");
             Assert.IsNull(unity["disabled"], "disabled should not be added for Cursor");
             Assert.IsNull(unity["type"], "type should not be added for non-VSCode clients");
         }

TestProjects/UnityMCPTests/Assets/Tests/EditMode/Windows/WriteToConfigTests.cs

@@ -96,7 +96,7 @@ public void AddsEnvAndDisabledFalse_ForKiro()
         }
 
         [Test]
-        public void AddsOnlyEnv_ForCursor()
+        public void DoesNotAddEnvOrDisabled_ForCursor()
         {
             var configPath = Path.Combine(_tempRoot, "cursor.json");
             WriteInitialConfig(configPath, isVSCode:false, command:_fakeUvPath, directory:"/old/path");
@@ -107,12 +107,12 @@ public void AddsOnlyEnv_ForCursor()
             var root = JObject.Parse(File.ReadAllText(configPath));
             var unity = (JObject)root.SelectToken("mcpServers.unityMCP");
             Assert.NotNull(unity, "Expected mcpServers.unityMCP node");
-            Assert.NotNull(unity["env"], "env should be present for all clients");
+            Assert.IsNull(unity["env"], "env should not be added for non-Windsurf/Kiro clients");
             Assert.IsNull(unity["disabled"], "disabled should not be added for non-Windsurf/Kiro clients");
         }
 
         [Test]
-        public void VSCode_AddsEnv_NoDisabled()
+        public void DoesNotAddEnvOrDisabled_ForVSCode()
         {
             var configPath = Path.Combine(_tempRoot, "vscode.json");
             WriteInitialConfig(configPath, isVSCode:true, command:_fakeUvPath, directory:"/old/path");
@@ -123,7 +123,7 @@ public void VSCode_AddsEnv_NoDisabled()
             var root = JObject.Parse(File.ReadAllText(configPath));
             var unity = (JObject)root.SelectToken("servers.unityMCP");
             Assert.NotNull(unity, "Expected servers.unityMCP node");
-            Assert.NotNull(unity["env"], "env should be present for VSCode as well");
+            Assert.IsNull(unity["env"], "env should not be added for VSCode client");
             Assert.IsNull(unity["disabled"], "disabled should not be added for VSCode client");
             Assert.AreEqual("stdio", (string)unity["type"], "VSCode entry should include type=stdio");
         }

UnityMcpBridge/Editor/Helpers/ConfigJsonBuilder.cs

@@ -62,13 +62,13 @@ private static void PopulateUnityNode(JObject unity, string uvPath, string direc
                 if (unity["type"] != null) unity.Remove("type");
             }
 
-            if (unity["env"] == null)
-            {
-                unity["env"] = new JObject();
-            }
-
             if (client != null && (client.mcpType == McpTypes.Windsurf || client.mcpType == McpTypes.Kiro))
             {
+                if (unity["env"] == null)
+                {
+                    unity["env"] = new JObject();
+                }
+
                 if (unity["disabled"] == null)
                 {
                     unity["disabled"] = false;