Improve Benchmark detection in Automatus #12554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SCE checks are inserted to SCAP source data stream in a form of `extended-component` element, each SCE check as a separate `extended-component` element. We shouldn't treat these extended component as XCCDF Benchmarks. Instead, when resolving a component reference we should check if the reference really points to an XCCDF Benchmark. This fix will remove these annoying messages from automatus output: ``` INFO - The data stream contains 132 Benchmarks INFO - 0 - scap_org.open-scap_cref_ssg-rhel9-xccdf.xml INFO - 1 - scap_org.open-scap_cref_rhel9-checks-sce-timer_dnf-automatic_enabled.sh INFO - 2 - scap_org.open-scap_cref_rhel9-checks-sce-service_debug-shell_disabled.sh INFO - 3 - scap_org.open-scap_cref_rhel9-checks-sce-service_pcscd_enabled.sh ... ```
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit fce616a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
Collaborator
Author
|
/packit build |
1 similar comment
Collaborator
Author
|
/packit build |
Member
|
/packit build |
Mab879
approved these changes
Oct 31, 2024
Member
|
/pakcit build |
Member
|
/packit build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCE checks are inserted to SCAP source data stream in a form of
extended-componentelement, each SCE check as a separateextended-componentelement. We shouldn't treat these extended component as XCCDF Benchmarks. Instead, when resolving a component reference we should check if the reference really points to an XCCDF Benchmark.This fix will remove these annoying messages from automatus output:
Review Hints:
build_productof a product where SCE checks are now enabled by default, eg.rhel9.automatustests of your favourite rule.automatusoutput with and without this patch.