Skip to content

Conversation

@rain-Qing
Copy link
Contributor

The Alibaba Cloud Linux CIS Benchmark has ceased updates and entered the End-of-Life (EOL) maintenance phase. Consequently, this pull request aims to remove the Alibaba Cloud Linux CIS-related profile and its associated references.

Changes include:

  1. Deletion of controls/cis_alinux2.yml controls/cis_alinux3.yml and its associated file.

  2. Removal of references to alinux2 and alinux3 CIS within the YAML files located in the linux_os/guide/ directory.

  3. Deletion the CIS-related profile files for alinux2 and alinux3 under the products directory.

Signed-off-by: Yuqing Yang [email protected]
Signed-off-by: YiLin.Li [email protected]

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 26, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2024

Hi @rain-Qing. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rain-Qing rain-Qing force-pushed the yuqing branch 2 times, most recently from efbd25d to 80196aa Compare January 26, 2024 09:15
@Mab879
Copy link
Member

Mab879 commented Jan 26, 2024

@rain-Qing please rebase this PR.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Jan 28, 2024
Yuqing Yang added 2 commits January 29, 2024 10:26
… has entered the End-of-Life (EOL) maintenance stage. As a result, the Alibaba Cloud Linux 2 CIS-related profile and its associated references will be removed.

Signed-off-by: Yuqing Yang <[email protected]>
Signed-off-by: YiLin.Li <[email protected]>
… has entered the End-of-Life (EOL) maintenance stage. As a result, the Alibaba Cloud Linux 3 CIS-related profile and its associated references will be removed.

Signed-off-by: Yuqing Yang <[email protected]>
Signed-off-by: YiLin.Li <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Jan 29, 2024
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 8f77cd3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.3% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the product-removal Issues or pull requests that relate to the removal of products. label Jan 29, 2024
@Mab879 Mab879 self-assigned this Jan 29, 2024
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@Mab879 Mab879 merged commit 17413f3 into ComplianceAsCode:master Jan 29, 2024
@marcusburghardt marcusburghardt added this to the 0.1.72 milestone Jan 29, 2024
@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. Alibaba Linux Alibaba Linux product related. and removed product-removal Issues or pull requests that relate to the removal of products. labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Alibaba Linux Alibaba Linux product related. CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants