Refactor dependency analysis to properly handle code imports, dependency keys, and package names #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184, Resolves #169, Resolves #93
This refactors the dependency analysis to be more robust when it comes to handling the differences between code imports, dependency keys and package names.
[target.'cfg(...)'.dependencies]dependencies.Here's a before and after for the errors messages:
Before:
After:
(syn doesn't support parsing
super letyet)I've also manually tested this against a few real-world projects (rustls, opentelemetry), and it looks to work well.